A code review in 2019 made me stop naming variables like a slob

My second month at a shop in Austin, a senior dev left a comment on my pull request that just said 'what is lunchTimeInMilliseconds vs lunchTimeMs?' I thought both were fine until he pointed out they were used in different files and one was a timestamp, the other a duration. He made me trace through 40 lines of math to see where I mixed them up. After that I started naming things by what they actually hold, like 'breakStartUnix' and 'breakDurationSec'. Has anyone else hit a bug that only appeared because two similar names meant two different things?

0 comments

Log in to join the discussion

Log In

0 Comments

No comments yet

Be the first to share your thoughts on this discussion.